This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [Patch] bug # 514 deja vu (cygwin console color handling)
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 23 Nov 2006 11:08:58 +0100
- Subject: Re: [Patch] bug # 514 deja vu (cygwin console color handling)
- References: <E1CeJAV-0007GT-00@mrelayng.kundenserver.de> <200611221720.kAMHKjP2020766@ns-srv-2.bln1.siemens.de>
- Reply-to: cygwin-patches at cygwin dot com
On Nov 22 18:20, Thomas Wolff wrote:
> I noticed that the reverse color bug
> http://sourceware.org/bugzilla/show_bug.cgi?id=514
> shows up again in recent cygwin1.dll updates. My previous patch
> is still in the source but additional code apparently has the same
> effect of rendering output unreadable; the effect is the following:
> * foreground is set bright
> * screen mode is set to reverse
> * cygwin wrongly assumes that the reverse foreground colour (which
> actually used to be the non-bright background color) should be
> set to bright, which is obviously a wrong idea and often results
> in a contrast that renders the output almost unreadable
>
> The attached shell script test514 demonstrates the bug.
> The attached patch is an attempt to fix the bug again.
> [...]
> * fhandler_console.cc (set_color): Avoid (again) inappropriate intensity
> interchanging that used to render reverse output unreadable
> when (non-reversed) text is bright.
> See http://sourceware.org/bugzilla/show_bug.cgi?id=514
Yup, that seems to do the trick. Thanks, applied.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat